Subject: Re: [xsl] XSLT Lint 0.1 From: Andriy Gerasika <andriy.gerasika@xxxxxxxxx> Date: Mon, 14 Feb 2011 17:37:18 +0200 |
While this is laudable, a refactoring like this one:
<!-- old --> <xsl:variable name="varName"> <xsl:value-of select="xpath"/> </xsl:variable> <!-- new --> <xsl:variable name="varName" select"xpath"/>
isn't safe without first doing a lot of semantic analysis. I think the preconditions for this to be correct are something like:
"all uses of $varName are dependent only its string value"
It looks to me as if your tool is trying to do refactorings based purely on local textual pattern matching. That might give good results 95% of the time, but 95% seems inadequate to me.
Current Thread |
---|
|
<- Previous | Index | Next -> |
---|---|---|
Re: [xsl] XSLT Lint 0.1, Michael Kay | Thread | Re: [xsl] XSLT Lint 0.1, Michael Kay |
[xsl] Re: The Binary Search Tree D, Dimitre Novatchev | Date | Re: [xsl] XSLT Lint 0.1, Michael Kay |
Month |