[xsl] Bad practice

Subject: [xsl] Bad practice
From: António Mota <amsmota@xxxxxxxxx>
Date: Fri, 8 Apr 2005 15:52:30 +0100
I hope this message gets to the list, cause my last fews seems that don't. 

What are the consequences of a construction like this in terms of
performance, and what about coding style?

I'm creating a table like this where diasemana.xml is a xml
representation of week days:

			<table id="{$t}" border="1">
				<xsl:for-each select="document('diassemana.xml')/dias/dia">
						<xsl:value-of select="@txt"/>
				<xsl:apply-templates select="/GHoras/Processos/Processo"/>

	<xsl:template match="Processo">
		<tr prK="{Processo_K}">
			<xsl:variable name="this" select="."/>
				<xsl:value-of select="NomeProcesso"/>
			<xsl:for-each select="document('diassemana.xml')/dias/dia">
				<xsl:variable name="pos" select="position()"/>
				<xsl:for-each select="$this">
					<xsl:call-template name="edhoras">
						<xsl:with-param name="dia" select="$pos"/>

This second use of document() serves only to do a 7th time loop,
without using any data, and the nested for-each is simply to change

Is this a bad practice?

Current Thread