Re: [xsl] user-defined XSLT functions and stylesheet variables?

["Eliot Kimber ekimber@xxxxxxxxxxxx" <xsl-list-service@xxxxxxxxxxxxxxxxxxxxxx>]

If I was given a style sheet with a function that used a global variable I would immediately rewrite the function to take that variable as a parameter.

 

Cheers,

 

E.

--

Eliot Kimber

http://contrext.com

 

 

 

From: "Liam R. E. Quin liam@xxxxxxxxxxxxxxxx" <xsl-list-service@xxxxxxxxxxxxxxxxxxxxxx>
Reply-To: <xsl-list@xxxxxxxxxxxxxxxxxxxxxx>
Date: Friday, June 18, 2021 at 12:56 PM
To: <xsl-list@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [xsl] user-defined XSLT functions and stylesheet variables?

 

On Fri, 2021-06-18 at 17:42 +0000, David Birnbaum djbpitt@xxxxxxxxx

wrote:

Dear XSLT-list,

 

Is there agreement about Best Practice with respect to using

stylesheet

(global) variables inside user-defined functions?

 

Tommie once gave a talk about best practice considered hamrful... :)

 

You've identified some of the issues, but for me the most important

ones are this:

(1) locality of reference: can i understand thefunction without having

to look elsewhere?

(2) maintainability: how easy will it be to fix problems in this

function in the future, or for someone else to change it, perhaps to

workslightly differently on edge cases. Assume they are in a hurry.

(3) can i take the function and reuse it in another stylesheet later?

 

Overall the use of global variables is likely to be an impediment to

each of these.

 

 

Liam

 

-- 

Liam Quin, https://www.delightfulcomputing.com/

Available for XML/Document/Information Architecture/XSLT/

XSL/XQuery/Web/Text Processing/A11Y training, work & consulting.

Barefoot Web-slave, antique illustrations:  http://www.fromoldbooks.org